feat: add contact_email to equinix_metal_connection datasource and resource #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source Signed-off-by: Marques Johansson <[email protected]>
displague
commented
Oct 13, 2023
displague
commented
Oct 13, 2023
displague
commented
Oct 13, 2023
| @@ -221,6 +228,11 @@ func resourceMetalConnectionCreate(d *schema.ResourceData, meta interface{}) err | |||
| Type: connType, | |||
| } | |||
|
|
|||
| // missing email is tolerated for user keys (can't be reasonably detected) | |||
| if contactEmail, ok := d.GetOk("contact_email"); ok { | |||
There was a problem hiding this comment.
nit: this doesn't match the ok pattern elsewhere
Signed-off-by: Marques Johansson <[email protected]>
ctreatma
approved these changes
Oct 16, 2023
| @@ -118,6 +121,7 @@ The following arguments are supported: | |||
| * `facility` - (**Deprecated**) Facility where the connection will be created. Use metro instead; read the [facility to metro migration guide](https://registry.terraform.io/providers/equinix/equinix/latest/docs/guides/migration_guide_facilities_to_metros_devices) | |||
| * `redundancy` - (Required) Connection redundancy - redundant or primary. | |||
| * `type` - (Required) Connection type - dedicated or shared. | |||
| * `contact_email` - (Required) The preferred email used for communication and notifications about the Equinix Fabric interconnection. Required when using a Project API key. Optional and defaults to the primary user email address when using a User API key. | |||
There was a problem hiding this comment.
Nit: I'm not totally sold on labeling this (Required), since it isn't always required; it looks like we went the opposite way with project_id, which is marked (Optional).
There was a problem hiding this comment.
Fair enough. I'll merge and change that in a subsequent PR so as not to offend the pass status on tests.
displague
deleted the
340-equinix_metal_connection-should-support-api-field-contact_email
branch
ctreatma
pushed a commit
that referenced
this pull request
Oct 16, 2023
…414) follow up to [#412 ](#412 (comment)) Signed-off-by: Marques Johansson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #340
note: