Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update terraform-plugin-sdk/v2 to v2.29.0 #405

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

t0mk
Copy link
Contributor

@t0mk t0mk commented Oct 9, 2023

Updating TF plugin sdk/v2 to latest in order to migrate to framework. Latest sdkv2 is one of the requirements for the migration.

towards #365

@t0mk t0mk temporarily deployed to internal October 9, 2023 11:10 — with GitHub Actions Inactive
@t0mk t0mk requested review from displague and ctreatma October 9, 2023 11:10
@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (872618d) 59.56% compared to head (645afab) 60.33%.
Report is 17 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   59.56%   60.33%   +0.77%     
==========================================
  Files          98       99       +1     
  Lines       19754    19889     +135     
==========================================
+ Hits        11767    12001     +234     
+ Misses       7684     7583     -101     
- Partials      303      305       +2     
Files Coverage Δ
equinix/data_source_metal_port.go 100.00% <100.00%> (ø)
equinix/data_source_metal_spot_market_request.go 89.89% <100.00%> (+6.06%) ⬆️
equinix/helpers_device.go 84.91% <100.00%> (+7.34%) ⬆️
equinix/provider.go 82.14% <100.00%> (+0.05%) ⬆️
equinix/resource_metal_port.go 89.84% <100.00%> (+1.64%) ⬆️
equinix/resource_metal_spot_market_request.go 62.50% <100.00%> (+4.82%) ⬆️
equinix/resource_metal_vrf.go 86.40% <100.00%> (-0.53%) ⬇️
equinix/data_source_metal_device_bgp_neighbors.go 97.65% <94.11%> (+26.56%) ⬆️
equinix/data_source_metal_vrf.go 89.58% <33.33%> (ø)
equinix/port_helpers.go 77.33% <81.81%> (+4.64%) ⬆️
... and 1 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@displague displague merged commit e0a9ac4 into main Oct 10, 2023
4 of 5 checks passed
@displague displague deleted the sdk-v2_v2.29.0 branch October 10, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants