Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Port2Azure Redundant Connection Example #397

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

thogarty
Copy link
Contributor

  • Add redundant connection example
  • Update README.md for both single and redundant connections
  • Update unused variables for both connections

In regards to #384, we will start to use the _e2e_ tests for regression testing for Fabric resources. At first locally but hopefully in GHA if we can get connecting to the lower environments from there.

@manu-equinix was of the mind that we could access UAT environments from GHA.

@thogarty thogarty temporarily deployed to internal September 29, 2023 22:01 — with GitHub Actions Inactive
… for both single and redundant Port2Azure Examples
@thogarty thogarty force-pushed the port2Azure-name-bandwidth-updates-CXF-75998 branch from 46166d2 to 38f505a Compare September 29, 2023 22:10
@thogarty thogarty temporarily deployed to internal September 29, 2023 22:11 — with GitHub Actions Inactive
@thogarty thogarty temporarily deployed to internal September 29, 2023 22:12 — with GitHub Actions Inactive
@thogarty thogarty temporarily deployed to internal September 29, 2023 22:14 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (872618d) 59.56% compared to head (fb57be1) 60.41%.
Report is 19 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   59.56%   60.41%   +0.84%     
==========================================
  Files          98       99       +1     
  Lines       19754    19889     +135     
==========================================
+ Hits        11767    12015     +248     
+ Misses       7684     7575     -109     
+ Partials      303      299       -4     
Files Coverage Δ
equinix/data_source_metal_port.go 100.00% <100.00%> (ø)
equinix/data_source_metal_spot_market_request.go 89.89% <100.00%> (+6.06%) ⬆️
equinix/helpers_device.go 84.91% <100.00%> (+7.34%) ⬆️
equinix/provider.go 82.14% <100.00%> (+0.05%) ⬆️
equinix/resource_metal_port.go 89.84% <100.00%> (+1.64%) ⬆️
equinix/resource_metal_spot_market_request.go 65.80% <100.00%> (+8.12%) ⬆️
equinix/resource_metal_vrf.go 86.40% <100.00%> (-0.53%) ⬇️
equinix/data_source_metal_device_bgp_neighbors.go 97.65% <94.11%> (+26.56%) ⬆️
equinix/data_source_metal_vrf.go 89.58% <33.33%> (ø)
equinix/port_helpers.go 77.33% <81.81%> (+4.64%) ⬆️
... and 1 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

source = "equinix/equinix"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing space is missing

@thogarty thogarty temporarily deployed to internal October 13, 2023 22:57 — with GitHub Actions Inactive
Copy link
Contributor

@srushti-patl srushti-patl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thogarty thogarty merged commit 3fe0e6a into main Oct 16, 2023
4 of 5 checks passed
@ctreatma ctreatma deleted the port2Azure-name-bandwidth-updates-CXF-75998 branch December 7, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants