-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add CODEOWNERS mapped by filenames #396
Conversation
CODEOWNERS
Outdated
# See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file | ||
# | ||
* @equinix/governor-devrel-engineering | ||
/cmd/migration-tool @equinix/governor-devrel-engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this one required? previous wildcard covers that pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect the wildcard could change over time and wanted to call out the specific add-on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe out of scope for this PR, but at what point does the migration tool go away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal would satisfy #295
CODEOWNERS
Outdated
# | ||
* @equinix/governor-devrel-engineering | ||
/cmd/migration-tool @equinix/governor-devrel-engineering | ||
*metal* @t0mk @equinix/governor-devrel-engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider creating a separate team for this for easier hand-off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctreatma squashed and rebased with @equinix/governor-metal-client-interfaces
Signed-off-by: Marques Johansson <[email protected]>
Co-authored-by: Charles Treatman <[email protected]> Signed-off-by: Marques Johansson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
===========================================
+ Coverage 44.71% 58.94% +14.22%
===========================================
Files 98 98
Lines 19888 19888
===========================================
+ Hits 8893 11722 +2829
+ Misses 10961 7874 -3087
- Partials 34 292 +258 ☔ View full report in Codecov by Sentry. |
Adds a codeowners using existing reviewer patterns.
The OWNERS file was a loosely tied benefit of:
#142 (comment)