Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CODEOWNERS mapped by filenames #396

Merged
merged 2 commits into from
Jan 24, 2024
Merged

chore: Add CODEOWNERS mapped by filenames #396

merged 2 commits into from
Jan 24, 2024

Conversation

displague
Copy link
Member

@displague displague commented Sep 29, 2023

Adds a codeowners using existing reviewer patterns.

The OWNERS file was a loosely tied benefit of:
#142 (comment)

@displague displague temporarily deployed to internal September 29, 2023 19:24 — with GitHub Actions Inactive
@displague displague requested a review from ctreatma October 3, 2023 11:52
CODEOWNERS Outdated
# See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file
#
* @equinix/governor-devrel-engineering
/cmd/migration-tool @equinix/governor-devrel-engineering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one required? previous wildcard covers that pattern

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect the wildcard could change over time and wanted to call out the specific add-on

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe out of scope for this PR, but at what point does the migration tool go away?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal would satisfy #295

CODEOWNERS Outdated
#
* @equinix/governor-devrel-engineering
/cmd/migration-tool @equinix/governor-devrel-engineering
*metal* @t0mk @equinix/governor-devrel-engineering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider creating a separate team for this for easier hand-off

Copy link
Member Author

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctreatma squashed and rebased with @equinix/governor-metal-client-interfaces

CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Charles Treatman <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a60c71f) 44.71% compared to head (b62d9d0) 58.94%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #396       +/-   ##
===========================================
+ Coverage   44.71%   58.94%   +14.22%     
===========================================
  Files          98       98               
  Lines       19888    19888               
===========================================
+ Hits         8893    11722     +2829     
+ Misses      10961     7874     -3087     
- Partials       34      292      +258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreatma ctreatma merged commit 0c69f14 into main Jan 24, 2024
4 of 5 checks passed
@ctreatma ctreatma deleted the codeowners branch January 24, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants