Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check out PR/branch code every time in acctest workflow #385

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

ctreatma
Copy link
Contributor

In an earlier PR, I missed that the acctest workflow checks out code both in the build job and in the test job. I updated the build job to check out PR code, but the test job was still checking out code from the base branch.

In an earlier PR, I missed that the acctest workflow checks out code
_both_ in the build job and in the test job.  I updated the build job
to check out PR code, but the test job was still checking out code
from the base branch.
@ctreatma ctreatma temporarily deployed to internal September 18, 2023 15:57 — with GitHub Actions Inactive
@ctreatma ctreatma temporarily deployed to internal September 18, 2023 15:57 — with GitHub Actions Inactive
@ctreatma ctreatma merged commit b891584 into main Sep 18, 2023
5 of 8 checks passed
@ctreatma ctreatma deleted the actually-run-pr-tests branch September 20, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant