refactor: use metal-go for the BGP neighbors data source
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
changed the title
metal-go for the BGP neighbors data sourcemetal-go for the BGP neighbors data source
ctreatma
force-pushed
the
metal-go-bgp-neighbors
branch
from
9311470 to
aedc757
Compare
ctreatma
force-pushed
the
metal-go-bgp-neighbors
branch
from
aedc757 to
b913082
Compare
ctreatma
requested a deployment
to
internal
GitHub Actions
Abandoned
ctreatma
requested a deployment
to
internal
GitHub Actions
Abandoned
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
===========================================
+ Coverage 13.73% 59.97% +46.23%
===========================================
Files 8 98 +90
Lines 910 19753 +18843
===========================================
+ Hits 125 11847 +11722
- Misses 770 7605 +6835
- Partials 15 301 +286
☔ View full report in Codecov by Sentry. |
ctreatma
force-pushed
the
metal-go-bgp-neighbors
branch
from
b913082 to
b69d3b1
Compare
ctreatma
commented
Sep 18, 2023
This updates the device BGP neighbors data source to use `metal-go` instead of `packngo`. There were no tests for the BGP neighbors data source, so those are added here as well.
ctreatma
force-pushed
the
metal-go-bgp-neighbors
branch
from
b69d3b1 to
f30b588
Compare
ctreatma
requested a deployment
to
internal
GitHub Actions
Abandoned
displague
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the device BGP neighbors data source to use
metal-goinstead ofpackngo. There were no tests for the BGP neighbors data source, so those are added here as well.