Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce metal-go client #353

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: introduce metal-go client #353

merged 1 commit into from
Aug 16, 2023

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Aug 7, 2023

This adds a metal-go client to the terraform provider. The metal-go client can be gradually adopted by Metal resources and data sources in this provider to enable the eventual deprecation of packngo.

An example of using this client to interact with the Metal API can be found in #291.

This adds a metal-go client to the terraform provider.  The metal-go
client can be gradually adopted by Metal resources and data sources
in this provider to enable the eventual deprecation of packngo.

An example of using this client to interact with the Metal API can
be found in #291.
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a few failed E2E tests here but nothing that can be associated with this change.

@displague displague merged commit 24cb78c into main Aug 16, 2023
@displague displague deleted the metal-go-setup branch August 16, 2023 14:25
@displague
Copy link
Member

displague commented Aug 16, 2023

a couple failed E2E tests were flakes triggered by seemingly intermittent networking or opaque upstream errors:

=== NAME  TestAccMetalOrganization_create
    resource_metal_organization_acc_test.go:53: Step 2/2 error: Error running apply: exit status 1
        
        Error: API Error HTTP 500 Oh snap, something went wrong! We've logged the error and will take a look - please reach out to us if you continue having trouble.
        
          with equinix_metal_organization.test,
          on terraform_plugin_test.tf line 14, in resource "equinix_metal_organization" "test":
          14: resource "equinix_metal_organization" "test" {
    resource_metal_port_acc_test.go:228: Step 1/3 error: Error running apply: exit status 1
        
        Error: API Error HTTP 500 Oh snap, something went wrong! We've logged the error and will take a look - please reach out to us if you continue having trouble.
        
          with equinix_metal_vlan.test2,
          on terraform_plugin_test.tf line 124, in resource "equinix_metal_vlan" "test2":
         124: resource "equinix_metal_vlan" "test2" {

#358

    resource_metal_device_acc_test.go:187: Step 1/1 error: Error running apply: exit status 1
        
        Error: API Error HTTP 422 Name must be 1-80 characters
        
          with equinix_metal_project.test,
          on terraform_plugin_test.tf line 76, in resource "equinix_metal_project" "test":
          76: resource "equinix_metal_project" "test" {
        
2023/08/08 15:03:26 [DEBUG] DELETE https://api.equinix.com/metal/v1/ssh-keys/79ee7e5b-2503-4d28-ac83-844f10ebeab7
--- FAIL: TestAccMetalDevice_sshConfig (6.74s)
=== NAME  TestAccMetalBGPSetup_basic
    resource_metal_bgp_setup_acc_test.go:15: Step 1/2 error: Error running apply: exit status 1
        
        Error: HTTP 504 Unexpected Content-Type text/html with status 504 Gateway Time-out
        
          with equinix_metal_bgp_session.test6,
          on terraform_plugin_test.tf line 101, in resource "equinix_metal_bgp_session" "test6":
         101: resource "equinix_metal_bgp_session" "test6" {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants