Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional metal_base (EQUINIX_API_METAL_BASE) provider config #338

Closed
wants to merge 1 commit into from

Conversation

displague
Copy link
Member

@displague displague commented Jun 2, 2023

Adds support for alternate Equinix Metal Base Path.
This is used in Prism spec validation: https://gist.github.com/displague/27363182851f0eab4b599401f83f4b1e.

There may not be other real-world test scenarios today outside of the use-case described. If there were a /metal/v1{suffix}, this could be helpful.

An alternative to this base path variable would be one that replaces the full Metal URL. This would provide ways to test against the legacy api.packet.net path structure (and other environments) for example.

@displague displague force-pushed the configurable_metal_base_path branch from 097e452 to 2f82bb8 Compare October 10, 2023 13:03
@displague displague temporarily deployed to internal October 10, 2023 13:03 — with GitHub Actions Inactive
@ctreatma
Copy link
Contributor

ctreatma commented Jan 5, 2024

I don't think we should do this. For the Prism case, that seems to be an issue with Prism (it doesn't respect the base path that is baked in to servers.0.url) and could possibly be worked around with something like this or by making a contribution to Prism that would have that proxy respect any base path in the specified server URL. For the api.packet.net case, IMO that should be difficult to configure; our customers should use (and be able to rely on) our standard api.equinix.com domains.

@displague
Copy link
Member Author

Closing based on @ctreatma's recommendations for alternate approaches and because we haven't seen the Spotlight integration manifest since this PR was created.

@displague displague closed this Jan 18, 2024
@ctreatma ctreatma deleted the configurable_metal_base_path branch August 6, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants