fix error check in networktype shim

equinix · Sep 29, 2023 · 19abaa2 · 19abaa2
1 parent ce9af22
commit 19abaa2
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/equinix/helpers_device.go b/equinix/helpers_device.go
@@ -130,13 +130,13 @@ func getNetworkInfo(ips []*packngo.IPAddressAssignment) NetworkInfo {
 }
 
 func getNetworkTypeMetalGo(device *metalv1.Device) (*string, error) {
-
 	pgDevice := packngo.Device{}
 	res, err := device.MarshalJSON()
-	if err != nil {
-		json.Unmarshal(res, pgDevice)
-		networkType := pgDevice.GetNetworkType()
-		return &networkType, nil
+	if err == nil {
+		if err = json.Unmarshal(res, &pgDevice); err == nil {
+			networkType := pgDevice.GetNetworkType()
+			return &networkType, nil
+		}
 	}
 	return nil, err
 }