Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial MVP- Palo Alto Firewall Module #8

Merged
merged 28 commits into from
Apr 29, 2024
Merged

initial MVP- Palo Alto Firewall Module #8

merged 28 commits into from
Apr 29, 2024

Conversation

kpdhulipala
Copy link
Contributor

initial MVP- Palo Alto Firewall Module - Onboarding terraform module to create network edge Palo Alto Firewall Device with three device management types (INTERNET -ACCESS, PRIVATE and INTERNET-ACCESS-WITH-PRVT-MGMT)

  1. Single device
  2. HA device
  3. Cluster device

Copy link

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one non-blocking comment about the docs; otherwise this looks good to me in terms of module structure and syntax.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@displague
Copy link
Member

I didn't see #9. I defer to #8 (comment) which came in a couple of minutes before my comments. The module structure looks good.

@schadalawada schadalawada merged commit f73f303 into main Apr 29, 2024
1 check passed
@schadalawada schadalawada deleted the NFV-28146 branch April 29, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants