Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade tf provider to 1.20.0 #48

Merged
merged 7 commits into from
Nov 17, 2023
Merged

feat: upgrade tf provider to 1.20.0 #48

merged 7 commits into from
Nov 17, 2023

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Nov 16, 2023 •
edited
Loading

Fixes https://github.com/equinix/pulumi-equinix/actions/runs/6894239945/job/18755591547

In the latest version of Terraform the config.go file has been changed to another module location so I had to manually update the patch accordingly

cd provider && go get github.com/equinix/[email protected]
cd ..
go work sync
FROM=v1.20.0 TO= make upstream.rebase
cd upstream
git checkout --theirs internal/config/config.go
git am --continue
cd ..
touch rebase-in-progress && make "upstream.finalize"
make build

@ocobles ocobles marked this pull request as draft November 16, 2023 18:19
ocobleseqx added 3 commits November 17, 2023 13:48
ocobleseqx added 2 commits November 17, 2023 13:50
fixup! rebase upstream
125818c 
Signed-off-by: ocobleseqx <[email protected]>
go work sync
4872af2 
Signed-off-by: ocobleseqx <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 2 breaking changes:

Types

  • 🟡 "equinix:fabric/ConnectionASideAccessPointInterface:ConnectionASideAccessPointInterface": properties: "id" type changed from "string" to "integer"
  • 🟡 "equinix:fabric/ConnectionZSideAccessPointInterface:ConnectionZSideAccessPointInterface": properties: "id" type changed from "string" to "integer"
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

make build
05ec2c7 
Signed-off-by: ocobleseqx <[email protected]>
@ocobles ocobles changed the title chore: update patches to match tf upstream new internal structure chore: update patches to match tf upstream new internal structure and upgrade tf provider to 1.20.0 Nov 17, 2023
@ocobles ocobles marked this pull request as ready for review November 17, 2023 14:40
@displague displague changed the title chore: update patches to match tf upstream new internal structure and upgrade tf provider to 1.20.0 feat: upgrade tf provider to 1.20.0 Nov 17, 2023
@ocobles ocobles merged commit 00a5f60 into main Nov 17, 2023
14 checks passed
@ocobles ocobles deleted the fix-patches branch November 17, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocobles @displague