-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add terraform provider as submodule and configure upstream script #24
Conversation
ocobles
commented
Oct 25, 2023
•
edited
Loading
edited
- Configure upstream
- Upgrade dependencies:
- golangci-lint v1.55.2
- gradle-version 7.6
- pulumi java generator v0.9.8
- pulumi sdk v3.91.1
- terraform provider v1.18.2
- Patch upstream to add a Pulumi user-agent (I have added this patch as a test to prove that it works correctly, but I will open some issues for other necessary patches, for example to eliminate references to terraform documentation)
- I have added gh actions to upgrade pulumi-terraform-bridge and provider, but it will require configuring a bot to be able to do it automatically
Signed-off-by: ocobleseqx <[email protected]>
Does the PR have any schema changes?Does the PR have any schema changes?Found 1 breaking change: Types
Maintainer note: consult the runbook for dealing with any breaking changes. |
Is this necessary? I imagine this may only be necessary for providers that have their In the Equinix TF Provider we intend to keep the Provider definition in the public https://github.com/equinix/terraform-provider-equinix/blob/main/equinix/provider.go#L47 |
@displague we could really go ahead without this, but the main intention is to have the ability to patch the upstream terraform provider https://github.com/pulumi/pulumi-linode/blob/45f0351a1026bc7d44234f365f0308e7884da343/scripts/upstream.sh#L96 For example to replace references to terraform registry that doesn't make sense in Pulumi documentation |
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trusting CI a bunch here; the combination of a bunch of different upgrades makes it hard to tease out what caused the various code changes. If we can, it would be nice to upgrade fewer things per PR in the future.