Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terraform provider as submodule and configure upstream script #24

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Oct 25, 2023

  • Configure upstream
  • Upgrade dependencies:
  1. golangci-lint v1.55.2
  2. gradle-version 7.6
  3. pulumi java generator v0.9.8
  4. pulumi sdk v3.91.1
  5. terraform provider v1.18.2
  • Patch upstream to add a Pulumi user-agent (I have added this patch as a test to prove that it works correctly, but I will open some issues for other necessary patches, for example to eliminate references to terraform documentation)
  • I have added gh actions to upgrade pulumi-terraform-bridge and provider, but it will require configuring a bot to be able to do it automatically

Signed-off-by: ocobleseqx <[email protected]>
@ocobles ocobles changed the title add terraform provider as submodule and configure upstream script feat: add terraform provider as submodule and configure upstream script Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 1 breaking change:

Types

  • 🟢 "equinix:metal/getDevicesDevice:getDevicesDevice": required: "sosHostname" property has changed to Required
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@displague
Copy link
Member

displague commented Oct 26, 2023

Is this necessary? I imagine this may only be necessary for providers that have their Provider definition locked away behind internal/.

In the Equinix TF Provider we intend to keep the Provider definition in the public equinix/ directory, as we move the resource definitions themselves to internal/.

https://github.com/equinix/terraform-provider-equinix/blob/main/equinix/provider.go#L47

@ocobles
Copy link
Contributor Author

ocobles commented Oct 26, 2023

@displague we could really go ahead without this, but the main intention is to have the ability to patch the upstream terraform provider https://github.com/pulumi/pulumi-linode/blob/45f0351a1026bc7d44234f365f0308e7884da343/scripts/upstream.sh#L96

For example to replace references to terraform registry that doesn't make sense in Pulumi documentation

@ocobles ocobles marked this pull request as ready for review October 26, 2023 17:19
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trusting CI a bunch here; the combination of a bunch of different upgrades makes it hard to tease out what caused the various code changes. If we can, it would be nice to upgrade fewer things per PR in the future.

@ocobles ocobles merged commit 345d05a into main Nov 6, 2023
14 checks passed
@ocobles ocobles mentioned this pull request Nov 6, 2023
@ctreatma ctreatma deleted the terraform_upstream branch August 21, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants