-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade terraform-provider-equinix to v2.6.0 #210
feat: Upgrade terraform-provider-equinix to v2.6.0 #210
Conversation
|
||
require ( | ||
github.com/equinix/pulumi-equinix/sdk latest | ||
github.com/pulumi/pulumi/sdk/v3 v3.128.0 | ||
github.com/pulumi/pulumi/sdk/v3 v3.133.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang it. The goal is to have the upgrade-provider
action only upgrade the upstream TF provider. How can we making these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like something went off the rails elsewhere; v3.133.0 was already adopted in main
at some point, but many of the examples are using the wrong version & this is fixing those examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#211 aims to get the examples back in sync. Once that is merged we can either rebase this PR or re-run the GitHub Action to create a new one so we can see what's left to resolve.
@@ -7,7 +7,7 @@ | |||
</PropertyGroup> | |||
<ItemGroup> | |||
<PackageReference Include="Pulumi" Version="3.*" /> | |||
<PackageReference Include="Pulumi.Equinix" Version="(, 1.0.0)" /> | |||
<PackageReference Include="Pulumi.Equinix" Version="0.18.1-alpha.1728498536+7525edd6" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the opposite of what we want. Did I break something in the previous PR that overwrites these versions in examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version number changes in examples seem like a problem (IIRC we run into difficulty ensuring that these version numbers are correct at release time?). In addition it'd be nice to not upgrade the pulumi SDK as part of the TF provider upgrade PR.
@@ -2,11 +2,11 @@ module equinix-fabric-cloud_router-example_1 | |||
|
|||
go 1.21 | |||
|
|||
toolchain go1.22.6 | |||
toolchain go1.21.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This golang downgrade is also unexpected. It looks like we use go 1.22 everywhere in GitHub Actions; where is 1.21 coming from?
The latest automated provider upgrade PR (#210) includes some unexpected changes to the examples. It looks like the examples were thrown out-of-sync by an earlier manual PR. This PR is the result of running `make tfgen` on `main`, and aims to bring the examples back in line with what would be produced by automation.
This PR was generated via
$ upgrade-provider equinix/pulumi-equinix --kind=provider --target-bridge-version=latest --pr-title-prefix=feat: --java-version=0.16.1
.