Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade terraform-provider-equinix to v2.5.0 #206

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Sep 20, 2024

This PR was generated via $ upgrade-provider equinix/pulumi-equinix --kind=provider --target-bridge-version=latest --pr-assign=ocobles --pr-title-prefix=feat:.


  • Updating Java Gen version from 0.14.0 to 0.16.1.
  • Upgrading terraform-provider-equinix from 2.4.1 to 2.5.0.

@ocobles ocobles self-assigned this Sep 20, 2024
@ocobles ocobles changed the title feat:Upgrade terraform-provider-equinix to v2.5.0 feat: Upgrade terraform-provider-equinix to v2.5.0 Sep 20, 2024
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 2 breaking changes:

Types

  • 🟢 "equinix:fabric/CloudRouterAccount:CloudRouterAccount": required: "accountNumber" property has changed to Required
  • 🟢 "equinix:fabric/getCloudRoutersData:getCloudRoutersData": required: "marketplaceSubscriptions" property has changed to Required

New functions:

  • fabric/getMarketplaceSubscription.getMarketplaceSubscription

Maintainer note: consult the runbook for dealing with any breaking changes.

0.16.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the provider upgrade fail with 0.14.0? The CI job avoids upgrading pulumi-java so that we can be confident we are only reviewing changes from the provider and not from elsewhere. Ideally we should replicate that behavior when manually upgrading the upstream provider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I executed the command upgrade-provider equinix/pulumi-equinix --kind=provider --target-bridge-version=latest --pr-assign=ocobles --pr-title-prefix=feat: without the --java-version arg and it seems that if you don't specify the java version it updates to the latest version available. However, I don't see any changes in the SDK generation and it fixes some bugs internally pulumi/pulumi-java@v0.14.0...v0.16.1

Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I noted a concern about upgrading multiple things at once, but it's not a blocker and could be addressed with documentation.

@ocobles ocobles merged commit 9ca0c50 into main Sep 23, 2024
16 of 17 checks passed
@ocobles ocobles deleted the upgrade-terraform-provider-equinix-to-v2.5.0 branch September 23, 2024 08:37
Copy link

This PR is included in version 0.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants