-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade terraform-provider-equinix to v2.5.0 #206
Conversation
Signed-off-by: Oscar Cobles <[email protected]>
Signed-off-by: Oscar Cobles <[email protected]>
Does the PR have any schema changes?Does the PR have any schema changes?Found 2 breaking changes: Types
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
0.16.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the provider upgrade fail with 0.14.0? The CI job avoids upgrading pulumi-java so that we can be confident we are only reviewing changes from the provider and not from elsewhere. Ideally we should replicate that behavior when manually upgrading the upstream provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I executed the command upgrade-provider equinix/pulumi-equinix --kind=provider --target-bridge-version=latest --pr-assign=ocobles --pr-title-prefix=feat:
without the --java-version
arg and it seems that if you don't specify the java version it updates to the latest version available. However, I don't see any changes in the SDK generation and it fixes some bugs internally pulumi/pulumi-java@v0.14.0...v0.16.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. I noted a concern about upgrading multiple things at once, but it's not a blocker and could be addressed with documentation.
This PR is included in version 0.18.0 🎉 |
This PR was generated via
$ upgrade-provider equinix/pulumi-equinix --kind=provider --target-bridge-version=latest --pr-assign=ocobles --pr-title-prefix=feat:
.