fix: generate examples failing bgp_session #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oscar Cobles <[email protected]>
|
Note: we will need to close issue #195 after merging this PR to let it create a new one |
|
hold on until #199 is merged |
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
ctreatma
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
ocobles
added a commit
that referenced
this pull request
Sep 18, 2024
The upstream version was accidentally updated in #198 https://github.com/equinix/pulumi-equinix/pull/198/files without applying the changes with a `make tfgen` & `make build_sdks` Forcing this update to apply the changes
|
This PR is included in version 0.18.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate examples was failing since some explicitly excluded examples had been renamed in terraform
"metal_bgp_session/example_1.tf" --> "equinix_metal_bgp_session/example_1.tf"
"metal_connection/*" --> "equinix_metal_connection/*"
I have also removed some manually created equinix_metal_connection examples, in order to use the ones available in Terraform.
However, some of them need to be fixed first in terraform equinix/terraform-provider-equinix#777, those still specified in the EXCLUDE_TF_EXAMPLES list
"equinix_metal_connection/shared_no_token_metal_to_fabric.tf"
"equinix_metal_connection/shared_token_fabric_port_to_metal.tf"
"equinix_metal_connection/shared_token_metal_to_csp.tf"
This will fix the issue in "https://github.com/equinix/pulumi-equinix/actions/runs/10692829858". Adding also ">&2" in the echo commands to ensure that log messages are sent to standard error output and we can trace them in the gh action