Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): switch to bot token for some GitHub Actions workflows #176

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

ctreatma
Copy link
Contributor

GitHub events generated by the built-in, automatic GitHub Actions token are explicitly ignored by GitHub Actions. This means that if an issue or pull request is created with the built-in token, that issue or pull request will not trigger other GitHub Actions workflows.

We previously worked around this issue by switching to scheduled workflows where necessary, but this leads to a large number of duplicate pull requests. Using a custom bot token for the upgrade-provider command allows us to roll back the move to scheduled jobs and rely on GitHub events to trigger the necessary workflows on-demand.

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@ocobles
Copy link
Contributor

ocobles commented Aug 27, 2024

adding some info: going back to the old workflow of creating an issue before running upgrade-provider will ensure that no duplicate issues or PRs are created
https://github.com/pulumi/upgrade-provider/blob/843f4efb4b7ed14a74822a470570fb7c21cca84f/upgrade/steps_helpers.go#L686-L703

@ctreatma ctreatma marked this pull request as ready for review August 27, 2024 20:39
@ctreatma ctreatma requested a review from ocobles August 27, 2024 20:40
@ocobles ocobles merged commit 5b01d27 into main Aug 28, 2024
17 checks passed
@ocobles ocobles deleted the actions-bot branch August 28, 2024 13:17
Copy link

This PR is included in version 0.17.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants