Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update schema generate examples #160

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Aug 20, 2024

we need #159 merged before this one to make sure that no new changes are discovered during the release process (the toolchain go1.22.6 in go.mod in the examples depends on the go version installed locally. In my case I have 1.22.5 while in the GH action we have 1.22.x so it can take a newer version)

Oscar Cobles added 2 commits August 20, 2024 18:21
@ocobles ocobles changed the title Update schema generate examples chore(ci): update schema generate examples Aug 20, 2024
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

ctreatma
ctreatma previously approved these changes Aug 20, 2024
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this ahead of #159 because we can validate this change by re-running the provider upgrade workflow after merge. We can still hold off on releasing until the release workflow is updated.

@ctreatma ctreatma dismissed their stale review August 20, 2024 17:17

CI failures seem important

@ctreatma
Copy link
Contributor

Dismissed my own approval because I noticed CI failures and they seem relevant. The build_sdk jobs are failing due to a dirty git tree: https://github.com/equinix/pulumi-equinix/actions/runs/10476042500/job/29014335287?pr=160#step:19:35

@ocobles
Copy link
Contributor Author

ocobles commented Aug 20, 2024

Dismissed my own approval because I noticed CI failures and they seem relevant. The build_sdk jobs are failing due to a dirty git tree: https://github.com/equinix/pulumi-equinix/actions/runs/10476042500/job/29014335287?pr=160#step:19:35

of course we need also a make build_sdks

@ctreatma ctreatma merged commit 54ceac9 into main Aug 20, 2024
15 checks passed
@ctreatma ctreatma deleted the update-schema-generate-examples branch August 20, 2024 18:26
Copy link

This PR is included in version 0.15.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants