Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove make tfgen from goreleaser #159

Merged
merged 2 commits into from
Aug 20, 2024
Merged

chore: remove make tfgen from goreleaser #159

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2146471
chore: use only_tfgen instead of tfgen in goreleaser
Aug 20, 2024
a6bec3d
fix:remove before hook
Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ archives:
name_template: "{{ .Binary }}-{{ .Tag }}-{{ .Os }}-{{ .Arch }}"
before:
hooks:
- make tfgen
- make only_tfgen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to

pulumi-equinix/.github/workflows/release.yml

Lines 60 to 61 in 2146471

- name: Build tfgen binary
run: make only_tfgen

So it looks like we run make only_tfgen, create the GH release, and then run make tfgen again via goreleaser? In that case I think we could remove this hook entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I think you're right

builds:
- binary: pulumi-resource-equinix
dir: provider
Expand Down
Loading