Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing pulumi-equinix/sdk version update #140

Closed
wants to merge 1 commit into from

Conversation

srushti-patl
Copy link
Contributor

This PR removes dirty from pulumi-equinix/sdk 0.14.0 version.

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@srushti-patl srushti-patl requested a review from displague August 14, 2024 19:57
@displague
Copy link
Member

displague commented Aug 14, 2024

Do we know how "dirty" got there? I see in the release action that there was some uncommitted diff in provider/cmd/pulumi-resource-equinix/schema.json that resulted in that action failing, marking the repo as dirty. Could that have triggered the dirty in the SDK go.mod?

Run goreleaser/goreleaser-action@v6
Downloading https://github.com/goreleaser/goreleaser/releases/download/v2.1.0/goreleaser_Linux_x86_64.tar.gz
Extracting GoReleaser
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/7cf50721-6590-43ea-84c8-b7b11f0ed3ff -f /home/runner/work/_temp/b0272e1c-[36](https://github.com/equinix/pulumi-equinix/actions/runs/10393580883/job/28782845874#step:13:37)38-42e9-9b58-a49d85589d69
GoReleaser ~> v2 installed successfully
/opt/hostedtoolcache/goreleaser-action/2.1.0/x64/goreleaser -p 3 release --clean --timeout 150m0s
  • loading environment variables
    • using token from $GITHUB_TOKEN
  • getting and validating git state
    • couldn't find any tags before "v0.15.0+dirty"
    • git state                                      commit=dac04d6877d6f17d8a[41](https://github.com/equinix/pulumi-equinix/actions/runs/10393580883/job/28782845874#step:13:42)90225bde9b4c7236679e branch=main current_tag=v0.15.0+dirty previous_tag=<unknown> dirty=true
  ⨯ release failed after 0s                  error=git is in a dirty state
Please check in your pipeline what can be changing the following files:
 M provider/cmd/pulumi-resource-equinix/schema.json

Learn more at https://goreleaser.com/errors/dirty

@displague
Copy link
Member

displague commented Aug 14, 2024

Since this is to address problems in the v0.15.0 release, should we be updating to v0.15.0? (or v0.15.1 since that is the next release).

@srushti-patl
Copy link
Contributor Author

Since this is to address problems in the v0.15.0 release, should we be updating to v0.15.0? (or v0.15.1 since that is the next release).

We can update it to 0.15.1

@@ -5,7 +5,7 @@ go 1.21
toolchain go1.22.6

require (
github.com/equinix/pulumi-equinix/sdk 0.14.0+dirty
github.com/equinix/pulumi-equinix/sdk 0.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will come back in the next release. There's something missing in the release process that is causing it to have a dirty work tree, so we'll need to find & fix that in order to fix this.

@ocobles
Copy link
Contributor

ocobles commented Aug 21, 2024

Closed in favor of #165

@ocobles ocobles closed this Aug 21, 2024
@ctreatma ctreatma deleted the pulumi-equinix-sdk-version-fix branch August 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants