Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle L1 block# in CommitBlockInfoV1 #41

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

tuommaki
Copy link
Collaborator

When exporting snapshot files from L1, each snapshot needs information where each storage log entry originated from, i.e. the L1 block number for given storage log entry. It's added to CommitBlockInfoV1 as an optional field which is not serialized into JSON.

zeapoz and others added 2 commits November 9, 2023 12:33
When exporting snapshot files from L1, each snapshot needs information
where each storage log entry originated from, i.e. the L1 block number
for given storage log entry. It's added to `CommitBlockInfoV1` as an
optional field which is not serialized into JSON.
@tuommaki tuommaki requested a review from zeapoz November 10, 2023 08:52
@tuommaki tuommaki self-assigned this Nov 10, 2023
Copy link
Member

@zeapoz zeapoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/export-snapshot to main November 16, 2023 10:36
@tuommaki tuommaki merged commit 48c7029 into main Nov 16, 2023
4 checks passed
@tuommaki tuommaki deleted the add-l1-block-nbr-to-commitblockinfo branch November 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants