Refactor add_cols functions
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the function categorised as
add_cols(including.add_dateand.add_infofunctions), with suggestions from PR #33. The updates include:.add_date_first_contact()and.add_date_last_contact()and renaming to.add_date_contact()to reduce duplicated code. This new function contains the argumentcontact_typeto select which type of date to add.tryCatch()are now made outside thetryCatch()rather than within to remove implicit assignment....) are no longer stored in a variable and a comment is added to explain why dots are checked in a vector over a list.apply_death_rate()internal function is fixed.Other functions that call
.add_date_contact()are updated, documentation and tests are updated and duplicated tests for.add_date_contact()are removed.