Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated superspreading 0.2.0 release blog post #166

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for tourmaline-marshmallow-241b40 ready!

Name Link
🔨 Latest commit 22de7ef
🔍 Latest deploy log https://app.netlify.com/sites/tourmaline-marshmallow-241b40/deploys/65b8f9c9aac50900083c4620
😎 Deploy Preview https://deploy-preview-166--tourmaline-marshmallow-241b40.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshwlambert
Copy link
Member

@Bisaloo is it worth manually hyperlinking the functions and PR tags so that this post has the same behaviour as the pkgdown site: https://epiverse-trace.github.io/superspreading/news/index.html?

@Bisaloo
Copy link
Member

Bisaloo commented Jan 30, 2024

@joshwlambert, thanks for the suggestion. As you can see in #169, some extra changes are required before this is fully functional. I have made the required changes in this post and everything should work once the other elements from #169 are solved.

In the meantime, I suggest merging the post as is to avoid having it go stale.

@joshwlambert
Copy link
Member

Thanks for the updates. Will be nice to have them automatically linked and I agree that merging the PR before waiting is best.

A possible change could be echo = FALSE to the R code block library(superspreading), do the readers need to know it is loaded for the linking? It'll be cleaner to have the linking work automagically.

@Bisaloo
Copy link
Member

Bisaloo commented Jan 30, 2024

A possible change could be echo = FALSE to the R code block library(superspreading), do the readers need to know it is loaded for the linking? It'll be cleaner to have the linking work automagically.

I had the same idea but for some reason, it looks like auto-linking doesn't work with echo = FALSE. Probably because it renders from the file in _freeze and chunks with echo = FALSE are absent there.

@joshwlambert
Copy link
Member

Thanks for the heads up.

@Bisaloo Bisaloo changed the title Automated release blog post Automated superspreading 0.2.0 release blog post Jan 31, 2024
@Bisaloo Bisaloo merged commit 79b7705 into main Jan 31, 2024
5 of 6 checks passed
@Bisaloo Bisaloo deleted the automated-release-post-1706571385 branch January 31, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants