-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor likelihood
functions
#58
Conversation
likelihood
function and fix log
argumentlikelihood
functions
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
===========================================
+ Coverage 39.95% 62.23% +22.28%
===========================================
Files 8 8
Lines 413 429 +16
===========================================
+ Hits 165 267 +102
+ Misses 248 162 -86
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
30d190d
to
2abc3b5
Compare
… is being calculated
…og-likelihood" all through
… is being calculated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff - left a few comments.
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
5ab7c85
to
564e2a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Co-authored-by: Sebastian Funk <[email protected]>
Thanks for your thorough review, @sbfnk. Really enjoyed the process. Will merge this after the checks pass. |
This PR closes #48 by ensuring that likelihoods and log-likelihoods are properly calculated. The
log
argument is removed fromoffspring_ll()
and retained inlikelihood()
to centralize the (log)likelihood and joint (log)likelihood calculations. The PR also adds tests to check the functionality of thelikelihood()
function as well as the*_ll()
functions to partly address #45.This PR also fixes a few minor issues, including:
*_ll()
family of functions.