-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interventions vignette (and remove intvn_reduce_mean argument) #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @sbfnk.
The deletions in the functions all LGTM.
The vignette is really insightful and highlights how to use the models with extra customizations through external functions suited to the user's use case.
I've added a few suggestions here and there.
Co-authored-by: James Azam <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 98.91% 98.82% -0.09%
==========================================
Files 9 8 -1
Lines 459 424 -35
==========================================
- Hits 454 419 -35
Misses 5 5
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
NEWS.md
Adds a vignette on how to model interventions.
n/a
n/a
Yes with respect to the previous development version, as it removes the
intvn_reduce_mean
argument.Closes #103