Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1130 and 1131 norc survey reset and incentive eligible tool #33

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open

Issue 1130 and 1131 norc survey reset and incentive eligible tool #33

wants to merge 22 commits into from

Conversation

Gbarra9
Copy link

@Gbarra9 Gbarra9 commented Nov 25, 2024 •
edited
Loading

This PR is related to the following:

Code changes:

  • Created an intermediary page for Norc's Data Correction Tools (dropdown to other tools)
  • Reroute old data corrections tool page
  • Created Survey Reset page (SSN Survey reset for now, others expected to be added in the future)
  • Created Incentive eligibility update tool

@Gbarra9 Gbarra9 marked this pull request as ready for review November 25, 2024 13:59
@Gbarra9 Gbarra9 requested review from a team, we-ai and amber-emmes and removed request for a team November 25, 2024 14:23
This was linked to issues Nov 25, 2024
NORC Survey Reset Tool episphere/connect#1130
Open
NORC enable incentive eligible episphere/connect#1131
Open
@Gbarra9 Gbarra9 changed the title Issue#1130 norc survey reset and incentive eligible tool Issue 1130 and 1131 norc survey reset and incentive eligible tool Nov 25, 2024
amber-emmes
amber-emmes reviewed Nov 25, 2024
View reviewed changes
Copy link

@amber-emmes amber-emmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good; some comments added.

index.js Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Show resolved Hide resolved
src/dataCorrectionsTool/surveyResetTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/surveyResetTool.js Outdated Show resolved Hide resolved
amber-emmes
amber-emmes approved these changes Nov 25, 2024
View reviewed changes
Copy link

@amber-emmes amber-emmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

we-ai
we-ai reviewed Nov 25, 2024
View reviewed changes
Copy link

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please double check document.getElementsByName('dataCorrectionLink').

src/dataCorrectionsTool/dataCorrectionsToolSelection.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/dataCorrectionsToolSelection.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/dataCorrectionsHelpers.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/dataCorrectionsHelpers.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/incentiveEligibilityTool.js Outdated Show resolved Hide resolved
src/dataCorrectionsTool/surveyResetTool.js Outdated Show resolved Hide resolved
@Gbarra9 Gbarra9 requested a review from we-ai November 26, 2024 18:08
we-ai
we-ai approved these changes Nov 26, 2024
View reviewed changes
Copy link

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Suggested a minor change for null handling.

src/dataCorrectionsTool/surveyResetTool.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amber-emmes amber-emmes amber-emmes approved these changes

@we-ai we-ai we-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NORC enable incentive eligible NORC Survey Reset Tool
3 participants
@Gbarra9 @we-ai @amber-emmes