Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await response from 'submit' endpoint #692

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

JoeArmani
Copy link
Collaborator

Related: episphere/connect#1168

Update the submit endpoint to await the response and return a response for all cases.

Implementation: This is used for response confirmation, in-app handling & communication, and question reversion when a response to a question fails to update server-side in Quest 2.

@JoeArmani JoeArmani requested review from a team, we-ai and Gbarra9 and removed request for a team November 26, 2024 15:32
Copy link
Collaborator

@Gbarra9 Gbarra9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the cleanups.
Comments on minor things.

utils/firestore.js Outdated Show resolved Hide resolved
utils/shared.js Outdated Show resolved Hide resolved
utils/submission.js Outdated Show resolved Hide resolved
utils/submission.js Show resolved Hide resolved
@JoeArmani JoeArmani merged commit b6f6317 into dev Dec 2, 2024
@JoeArmani JoeArmani deleted the response-from-submit-endpoint branch December 2, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectFaas/PWA: Update Response handling from Submit Endpoint
3 participants