Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky onboarding test #761

Merged
merged 1 commit into from
Jun 8, 2024
+6 −6
Merged

Fix flaky onboarding test #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/e2e/onboarding.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ test('completes onboarding after GitHub OAuth given valid user details', async (
await page.getByRole('button', { name: /signup with github/i }).click()

await expect(page).toHaveURL(/\/onboarding\/github/)
expect(
await expect(
page.getByText(new RegExp(`welcome aboard ${ghUser.primaryEmail}`, 'i')),
).toBeVisible()

Expand Down Expand Up @@ -222,7 +222,7 @@ test('logs user in after GitHub OAuth if they are already registered', async ({
await page.getByRole('button', { name: /signup with github/i }).click()

await expect(page).toHaveURL(`/`)
expect(
await expect(
page.getByText(
new RegExp(
`your "${ghUser!.profile.login}" github account has been connected`,
Expand All @@ -247,7 +247,7 @@ test('shows help texts on entering invalid details on onboarding page after GitH
await page.getByRole('button', { name: /signup with github/i }).click()

await expect(page).toHaveURL(/\/onboarding\/github/)
expect(
await expect(
page.getByText(new RegExp(`welcome aboard ${ghUser.primaryEmail}`, 'i')),
).toBeVisible()

Expand All @@ -257,15 +257,15 @@ test('shows help texts on entering invalid details on onboarding page after GitH
const createAccountButton = page.getByRole('button', {
name: /create an account/i,
})
expect(createAccountButton.getByRole('status')).not.toBeVisible()
expect(createAccountButton.getByText('error')).not.toBeAttached()
await expect(createAccountButton.getByRole('status')).not.toBeVisible()
await expect(createAccountButton.getByText('error')).not.toBeAttached()

// invalid chars in username
await usernameInput.fill('U$er_name') // $ is invalid char, see app/utils/user-validation.ts.
await createAccountButton.click()

await expect(createAccountButton.getByRole('status')).toBeVisible()
expect(createAccountButton.getByText('error')).toBeAttached()
await expect(createAccountButton.getByText('error')).toBeAttached()
await expect(
page.getByText(
/username can only include letters, numbers, and underscores/i,
Expand Down