upgrade to vite #624
Merged
upgrade to vite #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
commented
Feb 22, 2024
Comment on lines
+25
to
+30
| // This is for server-side utilities you want to colocate next to | ||
| // your routes without making an additional directory. | ||
| // If you need a route that includes "server" or "client" in the | ||
| // filename, use the escape brackets like: my-route.[server].tsx | ||
| '**/*.server.*', | ||
| '**/*.client.*', |
There was a problem hiding this comment.
This is probably the most significant change. It's the primary reason source code was changed. Remix with vite is more strict about your code that can end up in the client not using anything that's server-only so if you export anything other than the standard exports in a route that uses server-only code it'll error.
kentcdodds
commented
Feb 22, 2024
| export function loader({ request }: LoaderFunctionArgs) { | ||
| return generateSitemap(request, routes, { | ||
| export async function loader({ request, context }: LoaderFunctionArgs) { | ||
| const serverBuild = (await context.serverBuild) as ServerBuild |
There was a problem hiding this comment.
This was another interesting change because importing @remix-run/dev/server-build is not allowed in vite.
kentcdodds
commented
Feb 22, 2024
| serverBuild: getBuild(), | ||
| }), | ||
| mode: MODE, | ||
| // @sentry/remix needs to be updated to handle the function signature |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well this is great :)
https://remix.run/blog/remix-vite-stable