Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add general error boundary on cache routes #596

Conversation

paolapog
Copy link
Contributor

I've found a way to solve #583
Basically was missing a <GeneralErrorBoundary> component with its error handling component because if you were taking the error from the cache routes was resulting in an undefined result.
The error from general error boundary is an object with inside data that contains the error.

Test Plan

  1. Login to epic stack with a non-admin user
  2. Navigate to ./admin/cache route
  3. See the correct error being showed
    Screenshot 2024-01-12 at 11 33 56

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 04aecec into epicweb-dev:main Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants