Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Build / Cleanup README #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

simongregorebner
Copy link

Improve the build by adding a default configure directory (similar to whats in https://github.com/epics-extensions/ca-gateway)

Cleanup of the README

Added a standard configure directory (similar to the one used in the ca-gateway repository) for easier builds. Modified the Makefile to find the configure directory.
- Renamed README to README.md for better display on github.
- Removed old README.1st file that seemed to be irrelevant
- Added a section Build with build instructions for this extensions
@anjohnson
Copy link
Member

Hi Simon,

In principle I'm fine with this, thanks for submitting it. However could you please move the source files and their Makefile which builds everything into a src/ subdirectory. The new top-level Makefile should then include our standard configure/RULES_TOP which you can find in Base/templates/makeBaseApp/top/configure – ezca doesn't need the extra emtop stuff which I assume you just copied from the gateway's configure/RULES_TOP file.

Thanks,

  • Andrew

@simongregorebner
Copy link
Author

Using now the default Base/templates/makeBaseApp/top/configure from Epics base.

@MarkRivers
Copy link
Contributor

Is the plan that all extensions will switch to this new packaging, and the extensions/configure directory will no longer be used? I seem to be the maintainer for ezcaIDL and EzcaScan so should I be doing this?

@anjohnson
Copy link
Member

Hi Mark,

Is the plan that all extensions will switch to this new packaging, and the extensions/configure directory will no longer be used?

I think that's probably the best course of action. Different sets of tools can still be installed into a common bin/<arch> directory after conversion by setting INSTALL_LOCATION in their configure/CONFIG_SITE file.

The original extensions tree was designed for X11 and Motif applications but it doesn't really work for building programs that use newer toolkits like Qt, so more recent tools haven't been using it at all. I would like to drop support for the extensions configure area which combines many different sets of build rules, but I don't have time to help converting the existing tools myself.

Thanks,

  • Andrew

Copy link
Member

@anjohnson anjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Simon moved the source files back out of the new src/ directory again in commit 6bd7614 instead of creating a new Makefile in that directory to do the actual build. I don't like the current file structure, it just needs a bit more work after that commit to get it to build properly — I'd be happy to answer questions about what needs doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants