-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enum undef ts bug35 #43
base: master
Are you sure you want to change the base?
Fix enum undef ts bug35 #43
Conversation
…in file. This isn't really necessary, but it makes for a cleaner visual diff against the github master branch.
ef931b8
to
12002c9
Compare
This pull request fails the tests on all different architectures.
Please either fix the changes or the test. |
…bscription changes.
Looks like the test just needed to adjust the expected eventsReceived counts. |
Thanks a lot, Bruce! |
When support for propEventCB was added to the gateway, it subscribed to DBR_CTRL_* but calls both runDataCB and runValueDataCB. Since the DBR_CTRL_* events have zero in the timestamp fields and the value_data_callbacks assign the gdd from the DBR_CTRL* event to the gatePv value gdd, it can step on the timestamp from the DBR_TIME_* event.
I suspect the code in gatePvData::propEventCB was ignoring the first propEvent to avoid this bug but some cases get through and set the timestamp fields to zero, in particular mbbi and mbbo records.
This fix creates to subcriptions for DBE_PROPERTY events, one DBR_CTRL* subscription w/ propDataCB, and a DBR_TIME* subscription w/ propEventCB.