Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phoebus-setup-hook: add java heap size and change encoding by default for phoebus #97

Merged
merged 5 commits into from
Jan 23, 2025
Merged

phoebus-setup-hook: add java heap size and change encoding by default for phoebus #97

merged 5 commits into from
Jan 23, 2025

Conversation

Rider128
Copy link
Contributor

@Rider128 Rider128 commented Jun 4, 2024

No description provided.

@minijackson
Copy link
Collaborator

Can you also rename your commit to phoebus-setup-hook: … ?

@Rider128 Rider128 changed the title setup-hook: add java heap size and change encoding by default for phoebus phoebus-setup-hook: add java heap size and change encoding by default for phoebus Jun 5, 2024
@Rider128 Rider128 requested a review from minijackson November 4, 2024 13:18
@Rider128 Rider128 force-pushed the default-option-phoebus branch from d4a55fd to 53ae6af Compare November 7, 2024 08:25
minijackson
minijackson reviewed Nov 7, 2024
View reviewed changes
nixos/module-list.nix Outdated Show resolved Hide resolved
@Rider128 Rider128 force-pushed the default-option-phoebus branch from 53ae6af to da863ca Compare November 7, 2024 08:30
minijackson
minijackson requested changes Nov 7, 2024
View reviewed changes
pkgs/epnix/tools/phoebus/setup-hook/setup-hook.sh Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client-unwrapped/default.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client-unwrapped/default.nix Outdated Show resolved Hide resolved
nixos/modules/phoebus/client.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
@Rider128 Rider128 requested a review from minijackson November 8, 2024 16:02
minijackson
minijackson reviewed Nov 27, 2024
View reviewed changes
nixos/modules/phoebus/client.nix Outdated Show resolved Hide resolved
nixos/modules/phoebus/client.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
minijackson
minijackson requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the options you added won't be shown in the documentation. You'll need to add a docs/nixos-services/options-reference/phoebus-client.rst file, similar to the other files there.

pkgs/epnix/tools/phoebus/client/default.nix Outdated Show resolved Hide resolved
nixos/modules/phoebus/client.nix Outdated Show resolved Hide resolved
Rider128
Rider128 commented Dec 12, 2024
View reviewed changes
Copy link
Contributor Author

@Rider128 Rider128 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the options you added won't be shown in the documentation. You'll need to add a docs/nixos-services/options-reference/phoebus-client.rst file, similar to the other files there.

I add the file

Rider128

This comment was marked as duplicate.

Sign in to view

@Rider128 Rider128 force-pushed the default-option-phoebus branch from fa88bd6 to 783cab4 Compare January 8, 2025 15:33
minijackson
minijackson reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. Can you add a bit in the release notes, under a new section "New features" describing your module?

docs/nixos-services/options-reference/phoebus-client.rst Outdated Show resolved Hide resolved
@Rider128 Rider128 force-pushed the default-option-phoebus branch from 783cab4 to 607d52a Compare January 10, 2025 10:02
Matthieu Daniel-Thomas added 2 commits January 22, 2025 16:07
gitignore: update file for vscode
3b71d39
phoebus-client: add a wrapper
e95f6b3 
The wrapper was added for edit JAVA_OPTS in options.
@Rider128 Rider128 force-pushed the default-option-phoebus branch from 607d52a to 3247b0c Compare January 22, 2025 15:18
@minijackson minijackson added the backport nixos-24.11 Backport pull request to the nixos-24.11 branch label Jan 23, 2025
Matthieu Daniel-Thomas added 3 commits January 23, 2025 10:36
nixos/phoebus: add modules
06bfcbc 
Add the possibility to enable phoebus in a nixos configuration
Add the possibility to edit java_opts
docs: Documentation for phoebus client options
dc607b2
docs: Add release note for the new options
68cb91e
@Rider128 Rider128 force-pushed the default-option-phoebus branch from 5e424d6 to 68cb91e Compare January 23, 2025 09:37
minijackson
minijackson approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@minijackson minijackson merged commit 864aef3 into epics-extensions:master Jan 23, 2025
4 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for nixos-24.11:

@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minijackson minijackson minijackson approved these changes

Assignees
No one assigned
Labels
backport nixos-24.11 Backport pull request to the nixos-24.11 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rider128 @minijackson