No Kafka ElasticSearch enable magic #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minijackson
changed the title
stephane-cea
approved these changes
Feb 13, 2024
now the user must configure Kafka and ElasticSearch themselves
test would fail because the the list returned by phoebus-alarm-logger wouldn't be sorted by time, which we assumed was the case.
minijackson
force-pushed
the
no-kafka-elasticsearch-magic
branch
from
5870e02 to
8a99eee
Compare
|
Tests are ok except a time difference between the alarm time and the message time. |
minijackson
added a commit
to minijackson/EPNix
that referenced
this pull request
Jul 30, 2024
minijackson
added a commit
to minijackson/EPNix
that referenced
this pull request
Jul 30, 2024
see epics-extensions#75, epics-extensions#54, follow-up of epics-extensions#60 Specify in documentation that enabling ElasticSearch needs to be done only once.
minijackson
added a commit
to minijackson/EPNix
that referenced
this pull request
Jul 30, 2024
minijackson
added a commit
to minijackson/EPNix
that referenced
this pull request
Jul 30, 2024
see epics-extensions#75, epics-extensions#54, follow-up of epics-extensions#60 Specify in documentation that enabling ElasticSearch needs to be done only once.
minijackson
added a commit
to minijackson/EPNix
that referenced
this pull request
Aug 1, 2024
minijackson
added a commit
to minijackson/EPNix
that referenced
this pull request
Aug 1, 2024
see epics-extensions#75, epics-extensions#54, follow-up of epics-extensions#60 Specify in documentation that enabling ElasticSearch needs to be done only once.
minijackson
added a commit
to minijackson/EPNix
that referenced
this pull request
Aug 2, 2024
see epics-extensions#75, epics-extensions#54, follow-up of epics-extensions#60 Specify in documentation that enabling ElasticSearch needs to be done only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the logic where "if the Kafka server configured in phoebus-alarm-server/phoebus-alarm-logger is localhost, then automagically enable Kafka", and same for ElasticSearch.
Now the user always has to configure Kafka and ElasticSearch themselves, and we document how to do it in the Phoebus alarm guide.
Fixes #54.