Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add this line in Top templates to handle git submodules #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agaget
Copy link
Collaborator

@agaget agaget commented Dec 1, 2023

No description provided.

@agaget agaget requested a review from minijackson December 1, 2023 10:29
@agaget agaget added the bug Something isn't working label Dec 1, 2023
Copy link
Collaborator

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@minijackson
Copy link
Collaborator

Ah I almost forgot, could you change your commit message to something like:

templates/top: support SSH host syntax in gitlab-ci

and add a little description on why this was needed below?

@minijackson minijackson self-requested a review January 11, 2024 08:26
@agaget
Copy link
Collaborator Author

agaget commented Jan 11, 2024

Ah I almost forgot, could you change your commit message to something like:

templates/top: support SSH host syntax in gitlab-ci

and add a little description on why this was needed below?

I can't add a description, I can't remember why this was needed...

@minijackson
Copy link
Collaborator

minijackson commented Jan 11, 2024

This was because your submodules were specified as [email protected]:<repo>, and the GitLab CI couldn't clone them, because it doesn't have an SSH key. This git config replaces those SSH "URLs" by the HTTPS URL with the CI access token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants