-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phoebus-client: hardcode Python path for the console view #120
phoebus-client: hardcode Python path for the console view #120
Conversation
Upstream defaults to /usr/bin/python3, which doesn't exist on NixOS Fixes epics-extensions#100
Reading through the spec[1] and the warnings, it says that an application should have only one "Main Category" to prevent the application to be displayed in multiple places in the menu. Apparently, "Additional Categories" also automatically inherits from their "Main Category", so I had to remove a bunch. [1]: https://specifications.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Git push to origin failed for nixos-23.11 with exitcode 1 |
Successfully created backport PR for |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin nixos-23.05
git worktree add -d .worktree/backport/120-to-nixos-23.05 origin/nixos-23.05
cd .worktree/backport/120-to-nixos-23.05
git switch --create backport/120-to-nixos-23.05
git cherry-pick -x b333f3a0153e12908c61155022f15e3658f36568 d90443fecce486ab4e773d336e6e55069d744ef4 8562a1402d38825ddf3eb214abc9270ce922862e |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin nixos-23.05
git worktree add -d .worktree/backport/120-to-nixos-23.05 origin/nixos-23.05
cd .worktree/backport/120-to-nixos-23.05
git switch --create backport/120-to-nixos-23.05
git cherry-pick -x b333f3a0153e12908c61155022f15e3658f36568 d90443fecce486ab4e773d336e6e55069d744ef4 8562a1402d38825ddf3eb214abc9270ce922862e |
Upstream defaults to /usr/bin/python3, which doesn't exist on NixOS
Fixes #100
And some minor cleanup