Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: prerelease fixes #688

Merged
merged 18 commits into from
Jul 2, 2024
Merged

*: prerelease fixes #688

merged 18 commits into from
Jul 2, 2024

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Jun 19, 2024

on the way to v3, we have some stuff to iron out, tracked in #686.
taking over some from there.

  • update {Trainer,Model}.fit to return async iterators to follow progression of every part of processing. allows for more reactive UI as it refreshes on every batch rather on every round.
    • I don't really like how async iterators are handled in JS (no easy way to get return values), added an "utils" module to ease its use
    • there is not ETA but it helps users not get borded by a slow interface.
  • commonize branding to have the same "DISCO" everywhere
  • add demo notice
  • rework some webapp internals

@tharvik tharvik self-assigned this Jun 19, 2024
@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch from c4d12ed to c86b033 Compare June 21, 2024 09:05
@tharvik tharvik mentioned this pull request Jun 21, 2024
17 tasks
@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch 3 times, most recently from 01313bd to c011a11 Compare June 26, 2024 16:16
@tharvik tharvik changed the base branch from develop to UI-polishing June 26, 2024 16:16
@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch from c011a11 to 91a2844 Compare June 26, 2024 16:21
@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch from 91a2844 to e86b86d Compare June 27, 2024 11:33
@tharvik tharvik marked this pull request as ready for review June 27, 2024 12:18
Base automatically changed from UI-polishing to develop June 27, 2024 12:56
@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch 2 times, most recently from 847d130 to 28c7a2e Compare June 27, 2024 13:23
@tharvik tharvik requested a review from JulienVig June 27, 2024 13:23
@JulienVig
Copy link
Collaborator

Great work!! I'll review the implementation details next week.

I noticed a few UI things that I would change, like off centered buttons, small margins, I would also want to make the Demo warning a banner rather than a Card on the home page. If you want, I'm happy to tweak that myself next week (along with other things like the feedback form)
Screenshot 2024-06-27 at 15 53 41

@martinjaggi
Copy link
Member

for the async iter every batch vs every round: does it affect training speed or not much? (thinking of the cases where local iterations might be super fast but communication might be slow, which might often be the case)

@tharvik
Copy link
Collaborator Author

tharvik commented Jun 28, 2024

for the async iter every batch vs every round: does it affect training speed or not much? (thinking of the cases where local iterations might be super fast but communication might be slow, which might often be the case)

hum, not from what I remember. we didn't actively test with slow communications but it didn't seem like a high time cost in comparaison to the training (sub-seconds vs whole seconds). of course, if the network is very flaky, it might come as an issue.

@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch from 28c7a2e to 9ac364d Compare June 28, 2024 11:01
@tharvik
Copy link
Collaborator Author

tharvik commented Jun 28, 2024

like off centered buttons

ho good catch, I mixed two tailwindcss classes, fixed in the new commits.

small margins, I would also want to make the Demo warning a banner rather than a Card on the home page. If you want, I'm happy to tweak that myself next week (along with other things like the feedback form)

gladly, web UI is not really my strongest suit :)

@JulienVig
Copy link
Collaborator

gladly, web UI is not really my strongest suit :)

It's not mine either but I unfortunately have strong opinions on the matter... If that's fine with you I'll make changes in a follow-up PR rather than this one

@JulienVig JulienVig force-pushed the NAN-prerelease-fixes-tharvik branch from a4cd86f to a730240 Compare July 1, 2024 10:21
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! Mostly minor comments but a few important ones:

  • the preprocessing time measurement are now wrong
  • the chart animations are jerky

discojs/src/models/gpt/model.ts Show resolved Hide resolved
cli/src/benchmark_gpt.ts Outdated Show resolved Hide resolved
discojs/src/models/gpt/index.ts Show resolved Hide resolved
discojs/src/models/gpt/index.ts Show resolved Hide resolved
webapp/src/components/containers/ButtonsCard.vue Outdated Show resolved Hide resolved
webapp/src/components/home/Landing.vue Outdated Show resolved Hide resolved
webapp/src/components/information/Tutorial.vue Outdated Show resolved Hide resolved
webapp/src/components/pages/TaskList.vue Outdated Show resolved Hide resolved
@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch from 5a2f781 to 52050a6 Compare July 2, 2024 12:19
@tharvik tharvik mentioned this pull request Jul 2, 2024
7 tasks
@tharvik tharvik force-pushed the NAN-prerelease-fixes-tharvik branch from 0b51367 to b90b193 Compare July 2, 2024 13:34
@tharvik tharvik merged commit ea8e63c into develop Jul 2, 2024
23 checks passed
@tharvik tharvik deleted the NAN-prerelease-fixes-tharvik branch July 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants