-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gpt-tfjs bugs, add tests and refactor code #658
Conversation
@tharvik do you have an opinion on putting the gpt-tfjs test spec file, which relies on tfjs-node, in the |
for now, there isn't a good place to put theses tests, it's de facto in |
The thing is that this test is independent of the task, I tried to keep it as unitary as possible. It only tests gpt-tfjs implementation and capabilities |
ho, I misread, I though it was requiring discojs-node, not tfjs-node; well done then! so yeah, having it in discojs-core makes clearly sense. you can add tfjs-node to dev deps, so that's available for building/testing but not exposed from discojs-core (sadly not enforced). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouhou, we've a talking model, thanks!
mostly cosmetics changes, except for models/gpt
changes
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
discojs/discojs-core/src/dataset/data/preprocessing/text_preprocessing.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Valérian Rousset <[email protected]>
Co-authored-by: Valérian Rousset <[email protected]>
Co-authored-by: Valérian Rousset <[email protected]>
Co-authored-by: Valérian Rousset <[email protected]>
Co-authored-by: Valérian Rousset <[email protected]>
Co-authored-by: Valérian Rousset <[email protected]>
Co-authored-by: Valérian Rousset <[email protected]>
Addresses items listed in #654 #656
Fixes #656:
Addresses parts of #654
Additionally