-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some tests for l1 norm #21
Conversation
@mdeff why is travis not checking this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the CI. Linting however fails. Please fix the following:
./pyunlocbox/tests/test_functions.py:163:1: W293 blank line contains whitespace
./pyunlocbox/tests/test_functions.py:168:36: E231 missing whitespace after ','
./pyunlocbox/tests/test_functions.py:172:53: W291 trailing whitespace
./pyunlocbox/tests/test_functions.py:173:1: W293 blank line contains whitespace
./pyunlocbox/tests/test_functions.py:175:47: E231 missing whitespace after ','
./pyunlocbox/tests/test_functions.py:178:53: W291 trailing whitespace
./pyunlocbox/tests/test_functions.py:179:1: W293 blank line contains whitespace
./pyunlocbox/tests/test_functions.py:181:40: E251 unexpected spaces around keyword / parameter equals
./pyunlocbox/tests/test_functions.py:181:48: E231 missing whitespace after ','
./pyunlocbox/tests/test_functions.py:184:52: W291 trailing whitespace
./pyunlocbox/tests/test_functions.py:185:5: E301 expected 1 blank line, found 0
./pyunlocbox/tests/test_operators.py:407:46: E261 at least two spaces before inline comment
./pyunlocbox/tests/test_operators.py:408:1: W293 blank line contains whitespace
./pyunlocbox/tests/test_operators.py:409:1: W293 blank line contains whitespace
./pyunlocbox/tests/test_operators.py:412:1: E303 too many blank lines (4)
Tip: run make lint
locally to check for style issues.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Just added some tests for check related to issue #19