Add flatMap to the set class in the library #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelchassot
force-pushed
the
sam/set
branch
from
d8939b6 to
d7f8c8b
Compare
vkuncak
reviewed
Oct 16, 2024
| @@ -114,4 +126,7 @@ sealed case class Set[T](theSet: scala.collection.immutable.Set[T]) { | |||
|
|
|||
| def contains(a: T): Boolean = theSet.contains(a) | |||
| def subsetOf(b: Set[T]): Boolean = theSet.subsetOf(b.theSet) | |||
|
|
|||
| def exists(p: T => Boolean): Boolean = theSet.exists(p) | |||
There was a problem hiding this comment.
Is set.exists available to users? It does not seem like we have many properties of it known. If no, then it's a problem if it is used in spec of flatMap. If yes, we should probably add some axioms for it, like something returning an unspecified witness if a value exists and something instantiating property if it holds for all.
vkuncak
reviewed
Oct 16, 2024
|
One test is failing: I'm looking into it. |
|
It passes locally. It is maybe a timeout issue. |
|
I just ignored it with Princess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.