Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register watcher for closest component with form #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkulyk
Copy link

@dkulyk dkulyk commented Mar 17, 2021

If present few forms with same dependency watcher give values for all fields and forms works incorrectly.

@ragingdave
Copy link
Collaborator

Thanks for the contribution! Can you provide an example that would be an applicable case that this addresses?

@dkulyk
Copy link
Author

dkulyk commented Mar 17, 2021

Main form:

Restriction: Query
Query: ...

image
Second field in dependency container.

Inline creating form(last two fields):

Restriction: Mailing
Query: ...

image
Shows dependency for selected value in main form.

After patching package(last two fields):

Restriction: Mailing
Filter: ...

image
Works well

@dkulyk
Copy link
Author

dkulyk commented Mar 17, 2021

With actions same issue

@ragingdave
Copy link
Collaborator

If you have some time to submit a PR for the fix that'd be great.

@dkulyk
Copy link
Author

dkulyk commented Mar 24, 2021

If you have some time to submit a PR for the fix that'd be great.

This is PR.

@ragingdave
Copy link
Collaborator

oh, wow...long day sorry about that. I will try and take a look sometime tomorrow.
As far as the example, I was actually looking for code, not just the UI screenshots to be able to replicate your config and confirm that at least from my usages nothing breaks as well as confirm the fix does what it's supposed to do. I still don't really understand what it is you are fixing.

@dkulyk
Copy link
Author

dkulyk commented Mar 25, 2021

@dkulyk
Copy link
Author

dkulyk commented Apr 19, 2021

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants