Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nova-grid-system #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

happyDemon
Copy link

@happyDemon happyDemon commented Jul 13, 2020

add support for https://github.com/codenco-dev/nova-grid-system (remove the unneeded container)
also added field.class to the main container element

@happyDemon happyDemon changed the title Feature dependency container compatibility Add support for nova-grid-system Jul 13, 2020
@Slgoetz
Copy link

Slgoetz commented Aug 21, 2020

Would love to see this roll out in the next release!

@wize-wiz
Copy link
Contributor

@happyDemon I'll have a look the next coming days

@ragingdave
Copy link
Collaborator

Took a look here and I don't see anywhere in the nova code or in the nova-grid-system that adds a field.class property. Where specifically is that coming from? I don't disagree the addtl div is probably not required, but adding something that's field specific feels very specific to someone's specific usage.
Also if you do want to move forward, if you can remove the dist js you updated here. We will build prior to the next release.

@corgalore
Copy link

@happyDemon, this can get merged if you remove the compiled JS file (field.js) from the PR. Would love to have this right now.

@scramatte
Copy link

Hello, I need it for my project. Please fix PR to merge it ASAP. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants