Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agn cosmo fix #234

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

cjllorente827
Copy link
Collaborator

This branch contains fixes for the AGN particle code that allow AGN particles to spawn in cosmological simulations.

Important changes

  • AGN particles require location and time parameters to be set in order to spawn
  • AGN particles will spawn on the highest resolution grid available at the given location and time
  • AGN particles will be correctly transferred to a new grid when their location drifts out of their original grid

@bwoshea
Copy link
Contributor

bwoshea commented Feb 20, 2024

@cjllorente827 It seems that some of the tests are failing - it seems that there's a compilation issue. Could you please look into that? I suspect that one of your variables might be mis-typed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants