WIP: Individual star particles and feedback #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placed before, and PE heating was applied above 10^4 K
…lude radiating individual stars as requiring refinement to must refine level, even if no mass / energy feedback
…vior when mass above max bounds (e.g. switch to extrapolation)
…nzo-dev into enzo-emerick-uptodate
…r of 1.7 due to a normalization issue in how I computed the efficiency scaling
…hin a certain physical resolution
1) Paramter for including an R process model and associated
passive scalar tracer field. Models do nothing at the moment
2) Allow for AGB, SN, PopIII, and R Process tracer fields to be
saved as particle attributes if ouput chemical abundances is
turned off
3) Allowed for GalaxySimulation to use above species type
tracer fields
…d. Ensures the mapping of the sphere onto the grid has correct volume
…del field initialization in nested cosmology
…This really is a minor change
…rn to yields. This model is very simple and assumes yield table yields do not depend on surface abundances and just adds on surface abundances with no re-scaling
…e sensible places
…d physical radius rather than grid cell size
…eedback. A little bit worried this will do very bad things if particle is near the edge of a grid and feedback sphere overlaps with cells beyond the ghost zones. The feedback will be deposited correctly on the off-grid zones with the all star particle communication, but the routine may think its missing this volume and try and blow up the values to account for it (and if both grids do this then this is bad). Need to think about this some more. Still a problem even if feedback zone radius is <= number of ghost zones.
…ting to free memory that hasn't been allocated in StellarAbundances arrays on each grid. Just checking if IndividualStarOutputChemicalTags is used now every time this needs to be initialized or deleted so shouldn't be a problem?
…dividual star model
…ot sure why this didn't throw error earlier)
…PrintInfo. Optional verbose option in computing popIII-ness
…nzo-dev into enzo-emerick-uptodate
In commit 793c134 the TopGrid dimensions were forced to be even. However this was not applied to the routines that move particles between top grids. This mismatch led to memory corruption. It only caused problems in large top grids (>=512^3) and/or core counts when odd numbers were present.
* MPI bugfix: When summing up the particle mass flagging field, MPI messages would be mixed up, causing an MPI truncation error. Using a pseudo-unique tag instead of the one defined in macros_and_parameters.h * Fixed several minor memory errors and leaks during the course of debugging because I thought it was a memory corruption issue for a long time. * Improved MPI error reporting
bwoshea
changed the title
|
@kaleybrauer Thank you! I'm renaming this to 'WIP' because there are a bunch of merge conflicts that need to be resolved, and all of the tests are failing. Would you mind fixing those issues before we start reviewing the code? Thank you! |
|
@bwoshea Certainly! I just got back from traveling and will start addressing the tests and conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual star particles for all Pop II stars > 2 Msun, additional feedback models for the star particles, handling of many different metal tracers, bug fixes to handle hundreds of thousands of star particles