Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jekyll 4.3.1 #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to Jekyll 4.3.1 #347

wants to merge 1 commit into from

Conversation

breun
Copy link
Contributor

@breun breun commented Oct 29, 2022

Fixes #335
Fixes #346

@breun breun requested a review from envygeeks as a code owner October 29, 2022 23:20
@redonkulus
Copy link

@breun @envygeeks Can we get this merged and released? I'm looking to use the latest version of rouge (4.x) which is available in 4.3.x of jekyll. Thanks!

@breun
Copy link
Contributor Author

breun commented Nov 23, 2022

@redonkulus I don't have commit rights on this repository, I only created the pull request.

@coppolaemilio
Copy link

Could we maybe get @envygeeks 's blessing? 👼

@Periecle
Copy link

@breun, I suggest updating to 4.3.2 instead.

@envygeeks, do you think that can be merged?

@breun
Copy link
Contributor Author

breun commented Jan 29, 2023

@Periecle This MR has been open since October last year. It's gotten quiet here.

@Mte90
Copy link

Mte90 commented May 14, 2023

Any update?

@josegonzalez
Copy link

josegonzalez commented May 26, 2023

I think we want Jekyll 4.3.2 now (released Jan 20, 2023). That said, we'll probably also want to pin jekyll-sass-converter as the 3.0 version won't work with Alpine due to dart-sass-embedded usage (see sass/dart-sass-embedded#85).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Jekyll 4.3.1 Webrick gem not included anymore
6 participants