Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excplicit error on empty stack defaults #380

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Excplicit error on empty stack defaults #380

merged 1 commit into from
Mar 7, 2024

Conversation

viraptor
Copy link
Contributor

@viraptor viraptor commented Mar 7, 2024

Prevent an exception when then stack_defaults are empty.

@viraptor viraptor requested a review from orien March 7, 2024 02:31
orien
orien approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@orien orien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can define a schema and use a general-purpose validation tool to do this work.

@viraptor
Copy link
Contributor Author

viraptor commented Mar 7, 2024

That sounds way too reasonable... Maybe the next time I run into some failure.

@viraptor viraptor merged commit dc874a4 into master Mar 7, 2024
18 checks passed
@viraptor viraptor deleted the viraptor/nil_defaults branch March 7, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orien orien orien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viraptor @orien