-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.9.58 PR #773
1.9.58 PR #773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Opening curly brace does not appear on the same line as controlling statement.
entry-hw/app/modules/ProboConnect.js
Line 236 in 96380eb
{ |
Expected space(s) after "if".
entry-hw/app/modules/ProboConnect.js
Line 237 in 96380eb
if(this.checkSumCk(data)) { |
Missing semicolon.
entry-hw/app/modules/ProboConnect.js
Line 269 in 96380eb
this.InputData.Remote.R_5 = (data[11] & 0x10) ? 1 : 0 |
Operator '>>' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 279 in 96380eb
this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC; |
Operator '&' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 279 in 96380eb
this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC; |
Operator '>>' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 280 in 96380eb
this.InputData.Infinite.ROTATION_2 = (data[16]>>4)&0xC; |
Operator '&' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 280 in 96380eb
this.InputData.Infinite.ROTATION_2 = (data[16]>>4)&0xC; |
Operator '>>' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 281 in 96380eb
this.InputData.Infinite.ROTATION_3 = (data[16]>>2)&0xC; |
Operator '&' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 281 in 96380eb
this.InputData.Infinite.ROTATION_3 = (data[16]>>2)&0xC; |
Operator '>>' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 282 in 96380eb
this.InputData.Infinite.ROTATION_4 = (data[16]>>0)&0xC; |
Operator '&' must be spaced.
entry-hw/app/modules/ProboConnect.js
Line 282 in 96380eb
this.InputData.Infinite.ROTATION_4 = (data[16]>>0)&0xC; |
Block must not be padded by blank lines.
entry-hw/app/modules/ProboConnect.js
Line 321 in 96380eb
} |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 10 to 11 in 96380eb
rCmd1: 0xDA | |
}; |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 39 in 96380eb
textSize: 0 // 텍스트 크기는 따로 계산하여 입력한다. |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 65 to 66 in 96380eb
cs: 23 | |
}; |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 73 to 74 in 96380eb
motion: false | |
}; |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 102 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 107 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 112 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 117 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 118 to 119 in 96380eb
} | |
], |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 124 in 96380eb
state: [0, 0, 0, 0] // 값, 각도, 절대각도, 회전 수 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 130 in 96380eb
state: [0, 0, 0, 0, 0] // 값, 각도, 절대각도, 회전 수, 방향 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 148 to 149 in 96380eb
] | |
}; |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 243 to 244 in 96380eb
const size = data.length | |
if (size > this.length.version) { |
Block must not be padded by blank lines.
entry-hw/app/modules/alux_nemo.js
Line 269 in 96380eb
}; |
Block must not be padded by blank lines.
entry-hw/app/modules/alux_nemo.js
Line 317 in 96380eb
} |
Opening curly brace does not appear on the same line as controlling statement.
entry-hw/app/modules/alux_nemo.js
Line 323 in 96380eb
{ |
Expected indentation of 4 spaces but found 1 tab.
entry-hw/app/modules/alux_nemo.js
Line 339 in 96380eb
connect.close(); |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 351 to 352 in 96380eb
motion: false | |
}; |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 380 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 385 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 390 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 395 in 96380eb
state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 396 to 397 in 96380eb
} | |
], |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 402 in 96380eb
state: [0, 0, 0, 0, false, false, false] // 값, 각도, 절대각도, 회전 수, 눌려있을 때, 눌렀을 때, 뗐을 때 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Line 408 in 96380eb
state: [0, 0, 0, 0, 0] // 값, 각도, 절대각도, 회전 수, 방향 |
Missing trailing comma.
entry-hw/app/modules/alux_nemo.js
Lines 426 to 427 in 96380eb
] | |
}; |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 441 to 442 in 96380eb
this.device.accelA[3] = data[this.rAddr.accelALinear] | |
}; |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 454 to 455 in 96380eb
} | |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 458 to 459 in 96380eb
} | |
'diff' is never reassigned. Use 'const' instead.
entry-hw/app/modules/alux_nemo.js
Line 466 in 96380eb
let diff = this.deviceEx.expansion.last - this.deviceEx.expansion.curr; |
This line has a length of 124. Maximum allowed is 120.
entry-hw/app/modules/alux_nemo.js
Line 476 in 96380eb
this.deviceEx.expansion.state[0] = (sen - this.deviceEx.expansion.start) + (this.deviceEx.expansion.state[3] * 255); |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 490 to 491 in 96380eb
} | |
Unnecessary use of boolean literals in conditional expression.
entry-hw/app/modules/alux_nemo.js
Line 495 in 96380eb
this.device.exDigital[i - 4] = temp === 1 ? true : false; |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 501 to 502 in 96380eb
} | |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 508 to 509 in 96380eb
} | |
Unnecessary use of boolean literals in conditional expression.
entry-hw/app/modules/alux_nemo.js
Line 513 in 96380eb
? true |
Unnecessary use of boolean literals in conditional expression.
entry-hw/app/modules/alux_nemo.js
Line 516 in 96380eb
? true |
'diff' is never reassigned. Use 'const' instead.
entry-hw/app/modules/alux_nemo.js
Line 565 in 96380eb
let diff = this.deviceEx.compass.last - this.deviceEx.compass.curr; |
Unnecessary use of boolean literals in conditional expression.
entry-hw/app/modules/alux_nemo.js
Line 607 in 96380eb
? true |
Missing semicolon.
entry-hw/app/modules/alux_nemo.js
Lines 637 to 638 in 96380eb
} | |
Missing trailing comma.
Lines 482 to 483 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 490 to 491 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 498 to 499 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 506 to 507 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 514 to 515 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 527 to 528 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 540 to 541 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 549 to 550 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 558 to 559 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 580 to 581 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 597 to 598 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 621 to 622 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
Lines 631 to 632 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
There should be no space before this paren.
Line 674 in 96380eb
for (let i = 0; i < data.length; ) { |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 482 to 483 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 490 to 491 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 498 to 499 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 506 to 507 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 514 to 515 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 527 to 528 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 540 to 541 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 549 to 550 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 558 to 559 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 580 to 581 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 597 to 598 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 621 to 622 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
Missing trailing comma.
entry-hw/app/modules/choco2.js
Lines 631 to 632 in 96380eb
Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])]) | |
); |
There should be no space before this paren.
entry-hw/app/modules/choco2.js
Line 674 in 96380eb
for (let i = 0; i < data.length; ) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 65 in 96380eb
Module.prototype.init = function (handler, config) {}; |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 67 in 96380eb
Module.prototype.setSerialPort = function (sp) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 71 in 96380eb
Module.prototype.requestInitialData = function () { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 86 in 96380eb
Module.prototype.checkInitialData = function (data, config) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 90 in 96380eb
Module.prototype.afterConnect = function (that, cb) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 97 in 96380eb
Module.prototype.validateLocalData = function (data) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 102 in 96380eb
Module.prototype.requestRemoteData = function (handler) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 110 in 96380eb
Module.prototype.handleRemoteData = function (handler) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 194 in 96380eb
Module.prototype.requestLocalData = function () { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 232 in 96380eb
Module.prototype.handleLocalData = function (data) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 260 in 96380eb
Module.prototype.getDataByBuffer = function (buffer) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 272 in 96380eb
Module.prototype.disconnect = function (connect) { |
Unexpected space before function parentheses.
entry-hw/app/modules/neo_cannon.js
Line 279 in 96380eb
Module.prototype.reset = function () { |
BEA1:0, | ||
BEA2:0, | ||
BEA3:0, | ||
BEA4:0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing trailing comma.
BEA4:0 | |
BEA4:0, |
AA1: 0, | ||
AA2: 0, | ||
AA3: 0, | ||
AA4: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing trailing comma.
AA4: 0 | |
AA4: 0, |
BEA1:0, | ||
BEA2:0, | ||
BEA3:0, | ||
BEA4:0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing trailing comma.
BEA4:0 | |
BEA4:0, |
R_L1:0, | ||
R_L2:0, | ||
R_R1:0, | ||
R_R2:0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing trailing comma.
R_R2:0 | |
R_R2:0, |
ROTATION_1:0, | ||
ROTATION_2:0, | ||
ROTATION_3:0, | ||
ROTATION_4:0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing trailing comma.
ROTATION_4:0 | |
ROTATION_4:0, |
|
||
checkSumCk(buff){ | ||
var ck = 0; | ||
for(var i = 3 ; i < (buff[2] + 2) ; i++ ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no space before this paren.
for(var i = 3 ; i < (buff[2] + 2) ; i++ ) { | |
for(var i = 3 ; i < (buff[2] + 2) ; i++) { |
ck += buff[i]; | ||
} | ||
|
||
return buff[buff[2]+2] == (ck & 0xff) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operator '+' must be spaced.
return buff[buff[2]+2] == (ck & 0xff) | |
return buff[buff[2] + 2] == (ck & 0xff) |
return buff[buff[2]+2] == (ck & 0xff) | ||
? true | ||
: false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary use of boolean literals in conditional expression.
return buff[buff[2]+2] == (ck & 0xff) | |
? true | |
: false; | |
return buff[buff[2]+2] == (ck & 0xff); |
|
||
// 하드웨어에서 온 데이터 처리 | ||
handleLocalData(data) { | ||
if(data[0]==0xCD && data[1] == 0xDA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected space(s) after "if".
if(data[0]==0xCD && data[1] == 0xDA) | |
if (data[0]==0xCD && data[1] == 0xDA) |
|
||
// 하드웨어에서 온 데이터 처리 | ||
handleLocalData(data) { | ||
if(data[0]==0xCD && data[1] == 0xDA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operator '==' must be spaced.
if(data[0]==0xCD && data[1] == 0xDA) | |
if(data[0] == 0xCD && data[1] == 0xDA) |
#764