Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9.58 PR #773

Merged
merged 20 commits into from
Sep 24, 2024
Merged

1.9.58 PR #773

merged 20 commits into from
Sep 24, 2024

Conversation

Tnks2U
Copy link
Contributor

@Tnks2U Tnks2U commented Sep 24, 2024

@Tnks2U Tnks2U self-assigned this Sep 24, 2024
@Tnks2U Tnks2U merged commit 627b111 into master Sep 24, 2024
1 check passed
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] <brace-style> reported by reviewdog 🐶
Opening curly brace does not appear on the same line as controlling statement.


⚠️ [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".

if(this.checkSumCk(data)) {


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

this.InputData.Remote.R_5 = (data[11] & 0x10) ? 1 : 0


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '>>' must be spaced.

this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC;


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '&' must be spaced.

this.InputData.Infinite.ROTATION_1 = (data[16]>>6)&0xC;


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '>>' must be spaced.

this.InputData.Infinite.ROTATION_2 = (data[16]>>4)&0xC;


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '&' must be spaced.

this.InputData.Infinite.ROTATION_2 = (data[16]>>4)&0xC;


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '>>' must be spaced.

this.InputData.Infinite.ROTATION_3 = (data[16]>>2)&0xC;


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '&' must be spaced.

this.InputData.Infinite.ROTATION_3 = (data[16]>>2)&0xC;


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '>>' must be spaced.

this.InputData.Infinite.ROTATION_4 = (data[16]>>0)&0xC;


⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '&' must be spaced.

this.InputData.Infinite.ROTATION_4 = (data[16]>>0)&0xC;


⚠️ [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

rCmd1: 0xDA
};


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

textSize: 0 // 텍스트 크기는 따로 계산하여 입력한다.


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

cs: 23
};


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

motion: false
};


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

}
],


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [0, 0, 0, 0] // 값, 각도, 절대각도, 회전 수


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [0, 0, 0, 0, 0] // 값, 각도, 절대각도, 회전 수, 방향


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

]
};


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

const size = data.length
if (size > this.length.version) {


⚠️ [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.


⚠️ [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.


⚠️ [eslint] <brace-style> reported by reviewdog 🐶
Opening curly brace does not appear on the same line as controlling statement.


⚠️ [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 1 tab.

connect.close();


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

motion: false
};


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [false, false, false] // 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

}
],


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [0, 0, 0, 0, false, false, false] // 값, 각도, 절대각도, 회전 수, 눌려있을 때, 눌렀을 때, 뗐을 때


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

state: [0, 0, 0, 0, 0] // 값, 각도, 절대각도, 회전 수, 방향


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

]
};


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.

this.device.accelA[3] = data[this.rAddr.accelALinear]
};


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.


⚠️ [eslint] <prefer-const> reported by reviewdog 🐶
'diff' is never reassigned. Use 'const' instead.

let diff = this.deviceEx.expansion.last - this.deviceEx.expansion.curr;


⚠️ [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 124. Maximum allowed is 120.

this.deviceEx.expansion.state[0] = (sen - this.deviceEx.expansion.start) + (this.deviceEx.expansion.state[3] * 255);


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.


⚠️ [eslint] <no-unneeded-ternary> reported by reviewdog 🐶
Unnecessary use of boolean literals in conditional expression.

this.device.exDigital[i - 4] = temp === 1 ? true : false;


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.


⚠️ [eslint] <no-unneeded-ternary> reported by reviewdog 🐶
Unnecessary use of boolean literals in conditional expression.


⚠️ [eslint] <no-unneeded-ternary> reported by reviewdog 🐶
Unnecessary use of boolean literals in conditional expression.


⚠️ [eslint] <prefer-const> reported by reviewdog 🐶
'diff' is never reassigned. Use 'const' instead.

let diff = this.deviceEx.compass.last - this.deviceEx.compass.curr;


⚠️ [eslint] <no-unneeded-ternary> reported by reviewdog 🐶
Unnecessary use of boolean literals in conditional expression.


⚠️ [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <space-in-parens> reported by reviewdog 🐶
There should be no space before this paren.

for (let i = 0; i < data.length; ) {


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Buffer.concat([data, Buffer.from([crc & 0xff, (crc >> 8) & 0xff])])
);


⚠️ [eslint] <space-in-parens> reported by reviewdog 🐶
There should be no space before this paren.

for (let i = 0; i < data.length; ) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.init = function (handler, config) {};


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.setSerialPort = function (sp) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.requestInitialData = function () {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.checkInitialData = function (data, config) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.afterConnect = function (that, cb) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.validateLocalData = function (data) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.requestRemoteData = function (handler) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.handleRemoteData = function (handler) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.requestLocalData = function () {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.handleLocalData = function (data) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.getDataByBuffer = function (buffer) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.disconnect = function (connect) {


⚠️ [eslint] <space-before-function-paren> reported by reviewdog 🐶
Unexpected space before function parentheses.

Module.prototype.reset = function () {

BEA1:0,
BEA2:0,
BEA3:0,
BEA4:0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Suggested change
BEA4:0
BEA4:0,

AA1: 0,
AA2: 0,
AA3: 0,
AA4: 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Suggested change
AA4: 0
AA4: 0,

BEA1:0,
BEA2:0,
BEA3:0,
BEA4:0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Suggested change
BEA4:0
BEA4:0,

R_L1:0,
R_L2:0,
R_R1:0,
R_R2:0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Suggested change
R_R2:0
R_R2:0,

ROTATION_1:0,
ROTATION_2:0,
ROTATION_3:0,
ROTATION_4:0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.

Suggested change
ROTATION_4:0
ROTATION_4:0,


checkSumCk(buff){
var ck = 0;
for(var i = 3 ; i < (buff[2] + 2) ; i++ ) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-in-parens> reported by reviewdog 🐶
There should be no space before this paren.

Suggested change
for(var i = 3 ; i < (buff[2] + 2) ; i++ ) {
for(var i = 3 ; i < (buff[2] + 2) ; i++) {

ck += buff[i];
}

return buff[buff[2]+2] == (ck & 0xff)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '+' must be spaced.

Suggested change
return buff[buff[2]+2] == (ck & 0xff)
return buff[buff[2] + 2] == (ck & 0xff)

Comment on lines +228 to +230
return buff[buff[2]+2] == (ck & 0xff)
? true
: false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-unneeded-ternary> reported by reviewdog 🐶
Unnecessary use of boolean literals in conditional expression.

Suggested change
return buff[buff[2]+2] == (ck & 0xff)
? true
: false;
return buff[buff[2]+2] == (ck & 0xff);


// 하드웨어에서 온 데이터 처리
handleLocalData(data) {
if(data[0]==0xCD && data[1] == 0xDA)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".

Suggested change
if(data[0]==0xCD && data[1] == 0xDA)
if (data[0]==0xCD && data[1] == 0xDA)


// 하드웨어에서 온 데이터 처리
handleLocalData(data) {
if(data[0]==0xCD && data[1] == 0xDA)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '==' must be spaced.

Suggested change
if(data[0]==0xCD && data[1] == 0xDA)
if(data[0] == 0xCD && data[1] == 0xDA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants