Adjust re-exports #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Digests are not used at this level anymore
Pull Request Test Coverage Report for Build 11921849434Details
💛 - Coveralls |
dvdplm
approved these changes
Nov 19, 2024
Comment on lines
+8
to
+12
| use manul::protocol::{ | ||
| Artifact, BoxedRound, Deserializer, DirectMessage, EchoBroadcast, EntryPoint, FinalizeOutcome, LocalError, | ||
| MessageValidationError, NormalBroadcast, PartyId, Payload, Protocol, ProtocolError, ProtocolMessagePart, | ||
| ProtocolValidationError, ReceiveError, Round, RoundId, Serializer, | ||
| }; |
There was a problem hiding this comment.
What do you think about having a prelude when the code stabilizes a bit that users can *-import, giving them most of the basic types?
There was a problem hiding this comment.
Basically protocol and session are such preludes already, for two different types of users.
There was a problem hiding this comment.
There is a slight problem if you try to glob-import both, because they share LocalError and RemoteError. But a) perhaps they shouldn't (see #25), and b) I can't imagine a case where it would be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocol::digestre-export.digestandsignatureare now re-exported from the top level instead ofsession.