Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate user interrupt and terminating due to errors in SessionOutome #58

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 30, 2024

Fixes #19

terminate_due_to_errors() is kind of an awkward name, but I can't come up with anything better now.

Maybe we'll be able to select the reason automatically when #15 is fixed.

@coveralls
Copy link

coveralls commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11601312655

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 71.483%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/session/session.rs 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
manul/src/protocol/errors.rs 3 21.21%
manul/src/session/session.rs 5 76.58%
Totals Coverage Status
Change from base Build 11600676687: -0.3%
Covered Lines: 1514
Relevant Lines: 2118

💛 - Coveralls

@fjarri fjarri merged commit 445568c into entropyxyz:master Oct 30, 2024
8 checks passed
@fjarri fjarri deleted the terminate branch October 30, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a SessionOutcome::Terminated variant
2 participants