Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't serialize the already serialized payload when signing messages #55

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 30, 2024

Fixes #50

@fjarri fjarri merged commit 314e1a5 into entropyxyz:master Oct 30, 2024
8 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11599283915

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 71.157%

Files with Coverage Reduction New Missed Lines %
manul/src/session/session.rs 2 75.49%
Totals Coverage Status
Change from base Build 11598934687: 0.1%
Covered Lines: 1495
Relevant Lines: 2101

💛 - Coveralls

@fjarri fjarri deleted the single-serialize branch October 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid double serialization in SignedMessage::new()
2 participants