Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for simple broadcasts #47

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 25, 2024

Fixes #24

  • EchoBroadcast and DirectMessage now use ProtocolMessagePart trait for their methods.
  • Added normal broadcasts support in addition to echo ones; signatures of Round methods changed accordingly.
  • Added Round::make_normal_broadcast().
  • Added processing of a mismatched signature in the echoed broadcast. It is a provable error now.
  • Simplified creating an evidence for an echo round error (the TODO about SignedMessage being generic over signatures does not apply anymore)

@coveralls
Copy link

coveralls commented Oct 25, 2024

Pull Request Test Coverage Report for Build 11563351210

Details

  • 150 of 271 (55.35%) changed or added relevant lines in 10 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 70.794%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/session/message.rs 20 21 95.24%
manul/src/session/transcript.rs 18 21 85.71%
manul/src/protocol/errors.rs 2 10 20.0%
manul/src/protocol/message.rs 28 36 77.78%
manul/src/session/session.rs 22 31 70.97%
manul/src/protocol/round.rs 9 22 40.91%
manul/src/session/echo.rs 7 26 26.92%
manul/src/session/evidence.rs 27 87 31.03%
Files with Coverage Reduction New Missed Lines %
manul/src/session/echo.rs 1 65.97%
manul/src/session/session.rs 1 72.71%
manul/src/protocol/errors.rs 2 19.7%
manul/src/session/evidence.rs 2 42.31%
manul/src/protocol/message.rs 2 75.0%
Totals Coverage Status
Change from base Build 11562272589: 0.3%
Covered Lines: 1355
Relevant Lines: 1914

💛 - Coveralls

@fjarri fjarri force-pushed the simple-broadcasts branch 2 times, most recently from d588093 to 30eda1f Compare October 25, 2024 22:02
@fjarri fjarri force-pushed the simple-broadcasts branch 2 times, most recently from 3a7df67 to 7e80c65 Compare October 28, 2024 20:40
@fjarri fjarri marked this pull request as ready for review October 28, 2024 20:40
@fjarri fjarri force-pushed the simple-broadcasts branch from 7e80c65 to f1b2b3c Compare October 28, 2024 22:01
@fjarri fjarri merged commit 4d724bb into entropyxyz:master Oct 28, 2024
8 checks passed
@fjarri fjarri deleted the simple-broadcasts branch October 28, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add non-echo broadcast messages support?
2 participants